Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3-tuple i think #124

Merged
merged 10 commits into from
Mar 28, 2024
Merged

3-tuple i think #124

merged 10 commits into from
Mar 28, 2024

Conversation

MatthewRalston
Copy link
Owner

Adds new 3-tuple to the format spec contents. Closes #123 . Beginning work on #122 .

@MatthewRalston MatthewRalston added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers invalid This doesn't seem right labels Mar 5, 2024
@MatthewRalston MatthewRalston self-assigned this Mar 5, 2024
…ecord_and_detect_IUPAC. Default for base shred method set to true, so warnings are enables across .fa/.fq files. Default set to True throughout, so no question there. Default invocation (therefore suppressed) produces single warning for iupac module. 'Standard sequence' warning deprecated, it's lousy information. 789ish lines added. Adds/changes graph.py, __init__.py for edge graph creation 'graph' command. Bump version. Closes #123.

On other note, version bump for first inclusion of the graph structure into disk and memory. Beginning alternate pipeline of commands for assembly.

If i'm honest, the whole codebase needs a one over. Issue #124.
…ersion bumps, massive issues in __init__ graph.py kmer.py util.py. Refactor logging symmetry issues could spill over in fileutil if possible.

graph, __init__, kmer, util function abstractions, kmer.neighbor, logging changes, neighbor vs adjacency, pairs, new_type1_ids, new_type2_ids, char_first, char_last
@MatthewRalston MatthewRalston force-pushed the graph_algo branch 2 times, most recently from b7edfaf to e3eb1d8 Compare March 18, 2024 16:05
Creating masthead and usage notes for graph, but there's a lot of files and stats to keep track of.

I'm introducing the plan for the file "quick_stats.txt"

A summary file that provides tabular per-file k-mer counts, with associated metadata

I'm also at a comfortable state of the edge list generation loops.

There's a lot to be done and I don't know how much to document vs trusting in the intuitive nature of the interface.

Still working on personal issues, 20-30h work.

Honest assessment of myself.
…e board, version bump to v0.7.8. In this commit, tested on Cdiff_R3.fa (in test/data), the graph subcommand produces a valid metadata header, and writes the outputs to stdout and to the .kdbg file, and correctly asserts/validates the relationship between unique k-mers, unique nullomers, and the number of theoretically possible k-mers.
….fq files with improved logging, logs a warning about the observed inconsistencies and note about plausible origin from .fa/.fq input.
…Parser class into the parse submodule. wakka wakka!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers invalid This doesn't seem right
Projects
Status: Done
1 participant