-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3-tuple i think #124
Merged
Merged
3-tuple i think #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uded. minor update to .gitignore.
…y minor comments and syntax updates to fileutil.
MatthewRalston
added
bug
Something isn't working
documentation
Improvements or additions to documentation
enhancement
New feature or request
good first issue
Good for newcomers
invalid
This doesn't seem right
labels
Mar 5, 2024
…ecord_and_detect_IUPAC. Default for base shred method set to true, so warnings are enables across .fa/.fq files. Default set to True throughout, so no question there. Default invocation (therefore suppressed) produces single warning for iupac module. 'Standard sequence' warning deprecated, it's lousy information. 789ish lines added. Adds/changes graph.py, __init__.py for edge graph creation 'graph' command. Bump version. Closes #123. On other note, version bump for first inclusion of the graph structure into disk and memory. Beginning alternate pipeline of commands for assembly. If i'm honest, the whole codebase needs a one over. Issue #124.
MatthewRalston
force-pushed
the
graph_algo
branch
from
March 12, 2024 03:17
b2a37c3
to
7c387e6
Compare
…ersion bumps, massive issues in __init__ graph.py kmer.py util.py. Refactor logging symmetry issues could spill over in fileutil if possible. graph, __init__, kmer, util function abstractions, kmer.neighbor, logging changes, neighbor vs adjacency, pairs, new_type1_ids, new_type2_ids, char_first, char_last
MatthewRalston
force-pushed
the
graph_algo
branch
2 times, most recently
from
March 18, 2024 16:05
b7edfaf
to
e3eb1d8
Compare
Creating masthead and usage notes for graph, but there's a lot of files and stats to keep track of. I'm introducing the plan for the file "quick_stats.txt" A summary file that provides tabular per-file k-mer counts, with associated metadata I'm also at a comfortable state of the edge list generation loops. There's a lot to be done and I don't know how much to document vs trusting in the intuitive nature of the interface. Still working on personal issues, 20-30h work. Honest assessment of myself.
MatthewRalston
force-pushed
the
graph_algo
branch
from
March 18, 2024 16:42
e3eb1d8
to
d0f7799
Compare
This was referenced Mar 18, 2024
…e board, version bump to v0.7.8. In this commit, tested on Cdiff_R3.fa (in test/data), the graph subcommand produces a valid metadata header, and writes the outputs to stdout and to the .kdbg file, and correctly asserts/validates the relationship between unique k-mers, unique nullomers, and the number of theoretically possible k-mers.
….fq files with improved logging, logs a warning about the observed inconsistencies and note about plausible origin from .fa/.fq input.
…Parser class into the parse submodule. wakka wakka!
MatthewRalston
force-pushed
the
graph_algo
branch
from
March 28, 2024 17:42
be17281
to
dfe8bb2
Compare
MatthewRalston
force-pushed
the
graph_algo
branch
from
March 28, 2024 19:28
dfe8bb2
to
fce3a3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
documentation
Improvements or additions to documentation
enhancement
New feature or request
good first issue
Good for newcomers
invalid
This doesn't seem right
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new 3-tuple to the format spec contents. Closes #123 . Beginning work on #122 .