Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

__init__.py has duplicate storage of kmerid [smell] #114

Open
MatthewRalston opened this issue Feb 3, 2024 · 0 comments
Open

__init__.py has duplicate storage of kmerid [smell] #114

MatthewRalston opened this issue Feb 3, 2024 · 0 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers invalid This doesn't seem right wontfix This will not be worked on
Milestone

Comments

@MatthewRalston
Copy link
Owner

idx from enumerate loop is also the k-mer id. No need for kmer_ids[i] OR kmer_ids[idx]. Hesitating to fix until more info or refactoring proceeds.

See init.py#L1241

                        print("{0}\t{1}\t{2}\t{3}".format(i, kmer_ids[idx], counts[idx], frequencies[idx]))
                    kdb_out.write("{0}\t{1}\t{2}\t{3}\t{4}\n".format(i, kmer_ids[idx], counts[idx], frequencies[idx], json.dumps(kmer_metadata)))

kmer_ids[idx] == idx

Please fix.

@MatthewRalston MatthewRalston added bug Something isn't working enhancement New feature or request good first issue Good for newcomers invalid This doesn't seem right wontfix This will not be worked on labels Feb 3, 2024
@MatthewRalston MatthewRalston added this to the V0.7 stable? milestone Feb 3, 2024
@MatthewRalston MatthewRalston self-assigned this Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers invalid This doesn't seem right wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant