Enable support for SSH command restrictions due to 2FA at NEMO #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #322 +/- ##
=======================================
Coverage 98.87% 98.87%
=======================================
Files 55 55
Lines 2218 2222 +4
=======================================
+ Hits 2193 2197 +4
Misses 25 25 ☔ View full report in Codecov by Sentry. |
giffels
requested review from
a team,
mschnepf and
RHofsaess
and removed request for
a team
They are fixed in #315 and not related to the code changes. Please, ignore it. |
Merged
via the queue into
MatterMiners:master
with commit Nov 27, 2023
e841e1c
12 of 17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NEMO HPC is going to enable 2FA on the login nodes and SSH can be restricted to certain commands only. This requires to avoid
&&and$(whoami)in commands.This pull request changes the behaviour of the Moab site adapter to be compatible with that change.