Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparing TARDIS 0.8.0 release #300

Merged
merged 9 commits into from
Oct 10, 2023
Merged

Conversation

giffels
Copy link
Member

@giffels giffels commented Jul 17, 2023

Preparing TARDIS 0.8.0 release to

@giffels giffels changed the title Add changes for #298 to the documentation Preparing TARDIS 0.7.2 release Jul 17, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (c85ed76) 98.86% compared to head (779159c) 98.86%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #300   +/-   ##
=======================================
  Coverage   98.86%   98.86%           
=======================================
  Files          55       55           
  Lines        2210     2210           
=======================================
  Hits         2185     2185           
  Misses         25       25           
Files Coverage Δ
tardis/__about__.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@giffels giffels changed the title Preparing TARDIS 0.7.2 release Preparing TARDIS 0.8.0 release Jul 31, 2023
@giffels giffels self-assigned this Aug 4, 2023
@giffels giffels force-pushed the release-0.7.2 branch 3 times, most recently from 9d164d4 to db27088 Compare August 15, 2023 08:52
@giffels giffels marked this pull request as ready for review October 5, 2023 12:41
@giffels giffels requested review from a team, eileen-kuehn and rfvc and removed request for a team October 5, 2023 12:41
# Metadata for citation of this software according to the CFF format (https://citation-file-format.github.io/)
cff-version: 1.1.0
message: If you use this software, please cite it using these metadata.
title: "MatterMiners/tardis: 0.7.1"
Copy link
Member Author

@giffels giffels Oct 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is kind of a chicken and egg problem. I have to add the "link" to release 0.7.1, since this is the current one published on Zenodo and have to update it to version 0.8.0 once it is released.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't you just write 0.8.0? Because in time it is released, it will be valid?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but I do not know the doi of that version in advance.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could go with the generic doi for tardis itself as well. That's https://doi.org/10.5281/zenodo.2240605.

But I see no problem having the old version here until the release is made and then updating the info afterwards. It doesn't seem to get packaged, so it's not strictly attached to a version anyway - only the repo.

Copy link
Member

@maxfischer2781 maxfischer2781 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks simple enough. I've got a suggestion on the Citation issue but there's no need to make a change.

# Metadata for citation of this software according to the CFF format (https://citation-file-format.github.io/)
cff-version: 1.1.0
message: If you use this software, please cite it using these metadata.
title: "MatterMiners/tardis: 0.7.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could go with the generic doi for tardis itself as well. That's https://doi.org/10.5281/zenodo.2240605.

But I see no problem having the old version here until the release is made and then updating the info afterwards. It doesn't seem to get packaged, so it's not strictly attached to a version anyway - only the repo.

Copy link
Contributor

@rfvc rfvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@giffels giffels added this pull request to the merge queue Oct 10, 2023
Merged via the queue into MatterMiners:master with commit 1779157 Oct 10, 2023
17 checks passed
@giffels giffels deleted the release-0.7.2 branch October 10, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants