-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preparing TARDIS 0.8.0 release #300
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #300 +/- ##
=======================================
Coverage 98.86% 98.86%
=======================================
Files 55 55
Lines 2210 2210
=======================================
Hits 2185 2185
Misses 25 25
☔ View full report in Codecov by Sentry. |
9d164d4
to
db27088
Compare
# Metadata for citation of this software according to the CFF format (https://citation-file-format.github.io/) | ||
cff-version: 1.1.0 | ||
message: If you use this software, please cite it using these metadata. | ||
title: "MatterMiners/tardis: 0.7.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is kind of a chicken and egg problem. I have to add the "link" to release 0.7.1, since this is the current one published on Zenodo and have to update it to version 0.8.0 once it is released.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't you just write 0.8.0? Because in time it is released, it will be valid?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but I do not know the doi of that version in advance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could go with the generic doi for tardis itself as well. That's https://doi.org/10.5281/zenodo.2240605
.
But I see no problem having the old version here until the release is made and then updating the info afterwards. It doesn't seem to get packaged, so it's not strictly attached to a version anyway - only the repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks simple enough. I've got a suggestion on the Citation issue but there's no need to make a change.
# Metadata for citation of this software according to the CFF format (https://citation-file-format.github.io/) | ||
cff-version: 1.1.0 | ||
message: If you use this software, please cite it using these metadata. | ||
title: "MatterMiners/tardis: 0.7.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could go with the generic doi for tardis itself as well. That's https://doi.org/10.5281/zenodo.2240605
.
But I see no problem having the old version here until the release is made and then updating the info afterwards. It doesn't seem to get packaged, so it's not strictly attached to a version anyway - only the repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Preparing TARDIS 0.8.0 release to
resource_status
attribute crashing Prometheus plugin on newly started drones Ensure meaningful default for resource_status on new drones #301