Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically bump cargo.toml version to match package.json. #28

Closed
tegefaulkes opened this issue May 23, 2023 · 2 comments · Fixed by #29
Closed

Automatically bump cargo.toml version to match package.json. #28

tegefaulkes opened this issue May 23, 2023 · 2 comments · Fixed by #29
Assignees
Labels
development Standard development r&d:polykey:core activity 4 End to End Networking behind Consumer NAT Devices

Comments

@tegefaulkes
Copy link
Contributor

Specification

We need the cargo.toml version to match the package.json version for the CI release/prerelease jobs to work. This needs to happen between the npm version command bumping the version number and it committing the tag. There is a version script in the package.json that is run at that stage.

We need to create a script that will update the cargo.toml version to match the new version and make sure it is included in the version commit.

Additional context

Tasks

  1. create a version script to update the cargo.toml version.
  2. Make sure it's included within the version commit.
  3. Make sure that the pre-release and release CI jobs are passing and the package is being published.
@tegefaulkes tegefaulkes added the development Standard development label May 23, 2023
@tegefaulkes tegefaulkes self-assigned this May 23, 2023
@CMCDragonkai
Copy link
Member

Is there a PR for this?

@tegefaulkes
Copy link
Contributor Author

Not yet, I'm going to start on it now.

tegefaulkes added a commit that referenced this issue May 23, 2023
tegefaulkes added a commit that referenced this issue May 23, 2023
tegefaulkes added a commit that referenced this issue May 23, 2023
@CMCDragonkai CMCDragonkai added the r&d:polykey:core activity 4 End to End Networking behind Consumer NAT Devices label Jul 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Standard development r&d:polykey:core activity 4 End to End Networking behind Consumer NAT Devices
Development

Successfully merging a pull request may close this issue.

2 participants