Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest version breaks the leafy vegetables and vegetables tag #67

Open
Traehgniw opened this issue Jan 6, 2023 · 2 comments
Open

Latest version breaks the leafy vegetables and vegetables tag #67

Traehgniw opened this issue Jan 6, 2023 · 2 comments

Comments

@Traehgniw
Copy link

The latest version of phc2 crops causes some tags - leafy vegetables and vegetables for sure and possibly others - to break and become empty regardless of what other mods add things to them.
Crops 1.0.1 works just fine.

@christofferson
Copy link

I'm also having this issue in version 1.18.2-1.0.5.

A quick investigation of the server log reveals:

Server Log Snippet
[28Mar.2023 15:31:45.341] [Worker-Main-68/ERROR] [net.minecraft.tags.TagLoader/]: Couldn't load tag forge:cactus_plants as it is missing following references: #forge:cactus_plants/barrelcactus (from pamhc2crops-1.18.2-1.0.5.jar), 
  #forge:cactus_plants/nopales (from pamhc2crops-1.18.2-1.0.5.jar)
[28Mar.2023 15:31:45.343] [Worker-Main-68/ERROR] [net.minecraft.tags.TagLoader/]: Couldn't load tag forge:leafyvegetables/bokchoy as it is missing following references: pamhc2crops:bokchoy (from pamhc2crops-1.18.2-1.0.5.jar)
[28Mar.2023 15:31:45.367] [Worker-Main-68/ERROR] [net.minecraft.tags.TagLoader/]: Couldn't load tag forge:salad_ingredients/bokchoy as it is missing following references: pamhc2crops:bokchoy (from pamhc2crops-1.18.2-1.0.5.jar)
[28Mar.2023 15:31:45.367] [Worker-Main-68/ERROR] [net.minecraft.tags.TagLoader/]: Couldn't load tag forge:salad_ingredients as it is missing following references: #forge:salad_ingredients/bokchoy (from pamhc2crops-1.18.2-1.0.5.jar)
[28Mar.2023 15:31:45.381] [Worker-Main-68/ERROR] [net.minecraft.tags.TagLoader/]: Couldn't load tag forge:vegetables/bokchoy as it is missing following references: pamhc2crops:bokchoy (from pamhc2crops-1.18.2-1.0.5.jar)
[28Mar.2023 15:31:45.399] [Worker-Main-68/ERROR] [net.minecraft.tags.TagLoader/]: Couldn't load tag forge:leafyvegetables as it is missing following references: #forge:leafyvegetables/bokchoy (from pamhc2crops-1.18.2-1.0.5.jar)
[28Mar.2023 15:31:45.409] [Worker-Main-68/ERROR] [net.minecraft.tags.TagLoader/]: Couldn't load tag forge:vegetables as it is missing following references: #forge:vegetables/bokchoy (from pamhc2crops-1.18.2-1.0.5.jar)

Cross referencing that with the tags in the JAR's data directory confirms that the #forge:cactus_plants/barrelcactus and #forge:cactus_plants/nopales tags are missing and that all other tags are failing due to referencing pamhc2crops:bokchoy which seems to have been renamed to pamhc2crops:bokchoyitem.

@christofferson
Copy link

This data pack I put together quickly functions as a workaround for me, but if there are other mods that add bok choy it could cause those items to no longer have working tags as this uses "replace": true to override the broken tags in the mod.
pamhc2cropsfix.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants