Skip to content
This repository has been archived by the owner on Sep 23, 2023. It is now read-only.

Update scripts to use run.php #524

Open
catrope opened this issue Jan 19, 2023 · 1 comment
Open

Update scripts to use run.php #524

catrope opened this issue Jan 19, 2023 · 1 comment
Labels
maintenance Something is broken on the site, and immediate attention is needed to get things going again

Comments

@catrope
Copy link
Contributor

catrope commented Jan 19, 2023

Every maintenance script invocation in PatchDemo now outputs the following warning:

+ php /var/www/html/wikis/9c7b8d9c84/w/maintenance/createAndPromote.php Alice patchdemo1

*******************************************************************************
NOTE: Do not run maintenance scripts directly, use maintenance/run.php instead!
      Running scripts directly has been deprecated in MediaWiki 1.40.
      It may not work for some (or any) scripts in the future.
*******************************************************************************

done.

(For context, run.php was added by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/783428/ )

@MatmaRex
Copy link
Owner

Patch demo also supports creating wikis with older versions (I confirmed this works at least back to REL1_35, older versions may not work due to tooling incompatibilities), so this should be conditional or using a wrapper script of our own, which sounds annoying to add. Honestly I'd rather leave it like this until someone removes the ability to run scripts the old way, which I hope won't happen for some years ;)

I believe the warning is not supposed to be shown for automated processes like this, only in terminals (see https://gerrit.wikimedia.org/r/c/mediawiki/core/+/876792), so I'm not sure why it appears. Maybe that can be fixed instead.

@edg2s edg2s added the maintenance Something is broken on the site, and immediate attention is needed to get things going again label Jan 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintenance Something is broken on the site, and immediate attention is needed to get things going again
Projects
None yet
Development

No branches or pull requests

3 participants