You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The 3 modifiers share a lot of code, there might be a way to simplify this a bit, since they're all more or less specializations over a validator with multiple possible validations, and only really differ in the number of validations that can fail/pass. The TryFrom<Yaml> implementations for instance are almost identical, only differing in naming.
There's also some duplication in the PropertyType structure which will most likely also just increase over time as more modifiers are added:
The 3 modifiers share a lot of code, there might be a way to simplify this a bit, since they're all more or less specializations over a validator with multiple possible validations, and only really differ in the number of validations that can fail/pass. The
TryFrom<Yaml>
implementations for instance are almost identical, only differing in naming.There's also some duplication in the
PropertyType
structure which will most likely also just increase over time as more modifiers are added:yaml-validator/yaml-validator/src/lib.rs
Lines 119 to 153 in 7c09d93
The text was updated successfully, but these errors were encountered: