Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

orchestratord point balancers at environmentd internal port #30630

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

alex-hunt-materialize
Copy link
Contributor

Has orchestratord point balancers at the environmentd internal port.
Removes references to the deprecated environmentd balancer port.

Motivation

  • This PR fixes a previously unreported bug.
    Self-hosted installs could not connect through the balancer, as we haven't implemented auth yet.

  • This PR refactors existing code.
    Removes references to the deprecated environmentd balancer port.

Tips for reviewer

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

Copy link
Contributor

@doy-materialize doy-materialize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we do this, can we point the console at the balancer? i think that would simplify things

@alex-hunt-materialize
Copy link
Contributor Author

alex-hunt-materialize commented Nov 26, 2024

if we do this, can we point the console at the balancer? i think that would simplify things

Probably. I'll try that now.

@alex-hunt-materialize alex-hunt-materialize force-pushed the point_balancers_at_environmentd_internal_port branch from 416380b to 96a8942 Compare November 26, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants