-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep the generated mana in your pool during the whole turn #43
Comments
allentiak
changed the title
Game: keep the generated mana during the whole turn
Game: keep the generated mana in your pool during the whole turn
Apr 13, 2020
Interesting...
I know that I implemented it badly and if you pay more I'm not untapping
the land you didn't need.
I was bothered to add more logic for this "edge" case. I thought better to
spend time writing more logic somewhere else... but I'll definitely raise a
bug for it.
(There are plenty of small "edge" cases I didn't handle and need
adjustment).
On the other hand the rules are a little bit different :P
- *500.4*. When a step or phase ends, any unused mana left in a player’s
mana pool empties. This turnbased action doesn’t use the stack.
- https://media.wizards.com/2020/downloads/MagicCompRules%2020200122.pdf
…On Mon, 13 Apr 2020 at 05:54, Leandro Doctors ***@***.***> wrote:
If you tap more lands that needed for casting a certain spell, you should
still be able to cast another one at any point during the game whose cost
can be paid with what was left.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#43>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABCWP7SUMEH5E472PCFYLT3RMKLGXANCNFSM4MGWYHMA>
.
|
Created #44
On Mon, 13 Apr 2020 at 13:24, Antonio Alonzi <[email protected]>
wrote:
… Interesting...
I know that I implemented it badly and if you pay more I'm not untapping
the land you didn't need.
I was bothered to add more logic for this "edge" case. I thought better to
spend time writing more logic somewhere else... but I'll definitely raise a
bug for it.
(There are plenty of small "edge" cases I didn't handle and need
adjustment).
On the other hand the rules are a little bit different :P
- *500.4*. When a step or phase ends, any unused mana left in a player’s
mana pool empties. This turnbased action doesn’t use the stack.
- https://media.wizards.com/2020/downloads/MagicCompRules%2020200122.pdf
On Mon, 13 Apr 2020 at 05:54, Leandro Doctors ***@***.***>
wrote:
> If you tap more lands that needed for casting a certain spell, you should
> still be able to cast another one at any point during the game whose cost
> can be paid with what was left.
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <#43>, or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ABCWP7SUMEH5E472PCFYLT3RMKLGXANCNFSM4MGWYHMA>
> .
>
|
On Mon, 13 Apr 2020, 09:24 antonioalonzi85, ***@***.***> wrote:
Interesting...
I know that I implemented it badly and if you pay more I'm not untapping
the land you didn't need.
I was bothered to add more logic for this "edge" case. I thought better to
spend time writing more logic somewhere else... but I'll definitely raise a
bug for it.
(There are plenty of small "edge" cases I didn't handle and need
adjustment).
On the other hand the rules are a little bit different :P
- *500.4*. When a step or phase ends, any unused mana left in a player’s
mana pool empties. This turnbased action doesn’t use the stack.
- https://media.wizards.com/2020/downloads/MagicCompRules%2020200122.pdf
I didn't know about this... It's definitely been quite a while since my
last (physical) social gaming, ha ha. I even used to play with "mana burn"!
With all that into consideration, I your approach of untapping the lands
makes total sense. Does it happen after a successful cast, I guess?
… |
Yeah, if implemented it will.
The way I implemented the game is:
- The server at each action update the GameStatus
- The GameStatus is sent to the client that will rerender the entire view
after things have happened.
So the untapping logic can be added to the server (that has already a way
to calculate if mana paid was enough to cast the spell or ability).
It wasn't coming out of the box with the code I already had. So at that
time I left it unimplemented.
On Mon, 13 Apr 2020 at 17:13, Leandro Doctors <[email protected]>
wrote:
… On Mon, 13 Apr 2020, 09:24 antonioalonzi85, ***@***.***>
wrote:
> Interesting...
>
> I know that I implemented it badly and if you pay more I'm not untapping
> the land you didn't need.
> I was bothered to add more logic for this "edge" case. I thought better
to
> spend time writing more logic somewhere else... but I'll definitely
raise a
> bug for it.
> (There are plenty of small "edge" cases I didn't handle and need
> adjustment).
>
>
> On the other hand the rules are a little bit different :P
> - *500.4*. When a step or phase ends, any unused mana left in a player’s
> mana pool empties. This turnbased action doesn’t use the stack.
> - https://media.wizards.com/2020/downloads/MagicCompRules%2020200122.pdf
I didn't know about this... It's definitely been quite a while since my
last (physical) social gaming, ha ha. I even used to play with "mana burn"!
With all that into consideration, I your approach of untapping the lands
makes total sense. Does it happen after a successful cast, I guess?
>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#43 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABCWP7RJTAMDO36OHFAVXNTRMM22LANCNFSM4MGWYHMA>
.
|
antonioalonzi
changed the title
Game: keep the generated mana in your pool during the whole turn
keep the generated mana in your pool during the whole turn
Apr 28, 2020
antonioalonzi
changed the title
keep the generated mana in your pool during the whole turn
Keep the generated mana in your pool during the whole turn
Apr 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If you tap more lands that needed for casting a certain spell, you should still be able to cast another one at any point during the game whose cost can be paid with what was left.
The text was updated successfully, but these errors were encountered: