Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gird for Battle should work if targeting only one creature #3

Open
antonioalonzi opened this issue Oct 3, 2019 · 0 comments
Open
Labels
bug Something isn't working

Comments

@antonioalonzi
Copy link
Member

antonioalonzi commented Oct 3, 2019

TODOS:

  • Extend PutPlusOneCountersOnCreaturesTest adding an extra Gird for Battle to player hand.
  • At the end of the test add extra code to play it by targeting one only creature and click continue
  • Assert that spell is triggered and counter is added (test will fail as this functionality is not available)
  • ClientEventsReducer.CONTINUE_CLICK verify it enters into the if TurnUtils.getCardIdSelectedToBePlayed(newState) (make sure that the creature is cast).
  • the logic should be, only target with optional false should be mandatory. Targets with optional true can be omitted
  • CastService.cast() should be called on the backend and put the counter correctly (it already updates the UI with any changes to the GameStatus). I expect no changes in there.

I'm sure some changes are required, although cannot add any more info to this ticket without picking it up myself.

@antonioalonzi antonioalonzi modified the milestones: backlog, hacktoberfest Oct 3, 2019
@antonioalonzi antonioalonzi changed the title Gird for Battle should work if targeting only one creature 0002: Gird for Battle should work if targeting only one creature Oct 6, 2019
@antonioalonzi antonioalonzi added this to the backlong milestone Oct 6, 2019
@antonioalonzi antonioalonzi changed the title 0002: Gird for Battle should work if targeting only one creature Gird for Battle should work if targeting only one creature Oct 6, 2019
@antonioalonzi antonioalonzi added the bug Something isn't working label Oct 27, 2019
@antonioalonzi antonioalonzi removed this from the Backlog milestone Feb 22, 2020
@antonioalonzi antonioalonzi changed the title Gird for Battle should work if targeting only one creature Game: Gird for Battle should work if targeting only one creature Apr 11, 2020
@antonioalonzi antonioalonzi changed the title Game: Gird for Battle should work if targeting only one creature Gird for Battle should work if targeting only one creature Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant