Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Great project! Want any help? #138

Open
thesolution opened this issue Jun 13, 2024 · 4 comments
Open

Great project! Want any help? #138

thesolution opened this issue Jun 13, 2024 · 4 comments

Comments

@thesolution
Copy link

I stumbled upon this project and it's just what the doctor ordered for me! I need to read my public ip from the router and pynetgear worked first time!

I was not sure this project would work with my Nighthawk RAX40 router but I was able to grab the needed info! Thank you.

I was wondering if you were interested in help polishing this project up a little. Below are a few ideas of what I think I could help with.

Close Old Issues

It's time consuming to go over past issues and follow up for verify the issue is triaged or closed.

Delete Old Branches

It appears all the stale branches need to be checked and deleted.

Utilize GitHub Actions for builds

There are references to Travis CI and GitLab CI but no workflows for GH Actions. I haven't done anything like updating PyPI package versions... yet.

Contribute to Testing

Everyone hates writing unit tests but I'd like to help the project.

Contribute to Documentation

Maybe take some inspiration from gruijter/netgear.js.

Possibly Add a Sanity Test SubCommand that Reports Back

I think it would be useful to have a subcommand that let you run a sanity set of calls and lets the user what may/may not be supported. Optionally we could let the user report-back the results to a cheap/free data store like a google sheet.

This idea could be extended to auto generate a failure report that a user could copy into a GH Issue.

@starkillerOG
Copy link
Collaborator

Unfortunetly I do not have the right permission/acces to make Github Actions.
I have asked @MatMaul to give me those permissions but did not get a response yet.

@Seperis
Copy link

Seperis commented Oct 14, 2024

I'd also really like to help. I forked a personal version of pynetgear so I could add and test more methods I found in my logs, and I'd really love to be able to contribute. Currently I've gotten 38 new ones that work with my Orbi 6 that I've turned into working functions but this is literally the first time I've done anything like this and I'd love to share and see if I missed anything.

@starkillerOG
Copy link
Collaborator

You can always make pull requests to this repositry, I can review and merge when needed.

At some point I may fork and start my own library.
I have been planning to convert this to aiohttp and fully async, but have never found enough time....
Way too bussy with other projects like reolink.

@Seperis
Copy link

Seperis commented Oct 28, 2024

@starkillerOG Done. Sent the first sets of tested functions, all verified today. Most probably only apply to the Orbi 6 or netgear routers with multiple SSIDs, but a few also work on the RAX80. I have an RAX15 and I think RAX40 I am going to use to pitch hit for the RAX80 and retest a few functions since I've updated several.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants