-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Record format machine readability: retention time #306
Comments
Why not simply demanding a unit with numeric value, e.g. |
That would be the right thing to do. But we have a lot of legacy content in MassBank which does not define these units. Validation of all data is something like a unit test we use to ensure integrity of code and data on commits. Thats why we couldnt implement this test for the complete data. Lately I added -legacy as switch for the validator aa5b211 . Now our legacy content can be validated with less strict tests and I can implement this unit test for all new contributions. I will put this on my short term todo list. |
This concerns
Concerning 2) it was highlighted that there is an issue when the given unit is not explicitly given (i.e. RETENTION_TIME is just a number). I suggested to add an .ini (or other) file to contributor folders to provide missing info to the autocuration process (which might be needed also for other values.) @sneumann you weren't a big fan; do you have a better idea?
The text was updated successfully, but these errors were encountered: