Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove external dependencies #19

Open
scharc opened this issue Nov 11, 2022 · 1 comment
Open

remove external dependencies #19

scharc opened this issue Nov 11, 2022 · 1 comment
Labels
proposal A request to change something

Comments

@scharc
Copy link

scharc commented Nov 11, 2022

I like this simple approch of password protection and think it will help me on future projects but I have some privacy concerns about the external dependencies. could you move all the js / css files into the docker? It will not bloat the image and you pinned the dependencies in the index.html

@MarvinJWendt
Copy link
Owner

Yes, that makes sense. I just have to look up the licenses, as I am not sure if I may distribute the files in the repository.

@MarvinJWendt MarvinJWendt added the proposal A request to change something label Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal A request to change something
Projects
None yet
Development

No branches or pull requests

2 participants