Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: get_services missing descriptions #722

Open
Dorfieeee opened this issue Oct 9, 2024 · 3 comments
Open

API: get_services missing descriptions #722

Dorfieeee opened this issue Oct 9, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@Dorfieeee
Copy link
Collaborator

Most of the services are missing descriptive texts - info.
image

Let's update and expand the current service info and add the missing ones.

@Dorfieeee Dorfieeee added the enhancement New feature or request label Oct 9, 2024
@Dorfieeee Dorfieeee changed the title get_services missing descriptions API: GET get_services missing descriptions Oct 9, 2024
@Dorfieeee Dorfieeee changed the title API: GET get_services missing descriptions API: get_services missing descriptions Oct 9, 2024
@ElGuillermo
Copy link
Collaborator

ElGuillermo commented Oct 9, 2024

Here ?

def get_services(request):

Can't we find a way to describe the services elsewhere ? This way will force to update the services.py file everytime a new service will be added, either in the master branch or locally, by users.
IMHO, the best way of doing it would be to add a 'description' environment field in the supervisord.conf file for each service (see this).

@cemathey
Copy link
Collaborator

Here ?

def get_services(request):

Can't we find a way to describe the services elsewhere ? This way will force to update the services.py file everytime a new service will be added, either in the master branch or locally, by users. IMHO, the best way of doing it would be to add a 'description' environment field in the supervisord.conf file for each service (see this).

I didn't see anything in the supervisord conf that would let us set a description, can you link to it specifically?

@ElGuillermo
Copy link
Collaborator

I imagined we could set an environment variable to add the description, as described here :
A list of key/value pairs in the form KEY="val",KEY2="val2" that will be placed in the environment of all child processes.

ie :

[program:expiring_vips]
command=/code/manage.py expiring_vips
environment=LOGGING_FILENAME="expiring_vips_%(ENV_SERVER_NUMBER)s.log",DESC="Disable expired VIPs"
startretries=10
autorestart=true

?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants