Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some components currently don't take advantage of L.options.locale #568

Closed
ahmadayubi opened this issue Nov 10, 2021 · 3 comments
Closed
Labels
enhancement user preferences Allow user to set a remembered value across domains

Comments

@ahmadayubi
Copy link
Member

Currently the following components don't use M.options.locale:

  • zoom buttons
  • full screen button

This prevents translation to the user agents language of preference through the mapml-extension. Feel free to add other componenets that could also benefit from using L.options.locale.

@Malvoz Malvoz added the user preferences Allow user to set a remembered value across domains label Nov 13, 2021
@Malvoz
Copy link
Member

Malvoz commented Nov 13, 2021

@Malvoz
Copy link
Member

Malvoz commented Nov 13, 2021

Also:

@Malvoz Malvoz mentioned this issue Nov 27, 2021
@prushforth
Copy link
Member

Closing, because I believe all these issues were resolved by this commit as well as recent commits in the mapml-extension

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement user preferences Allow user to set a remembered value across domains
Projects
None yet
Development

No branches or pull requests

3 participants