We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
<a role="button">
<button type="button">
It's recommended to use <button> instead of <a role="button">. We should change the use of <a> in all places we've introduced them:
<button>
<a>
This would require a CSS reset to make buttons look seamless by default, e.g.:
.mapml-button { background-color: transparent; border: none; border-radius: 0; color: inherit; font: inherit; line-height: inherit; margin: 0; padding: 0; overflow: hidden; text-align: left; text-align: inline-start; text-transform: none; -webkit-appearance: none; -moz-appearance: none; appearance: none; }
(This generic button class was originally proposed in #263 (comment).)
Info on <a> vs <button>:
This issue relates to #19 (same problem but keeping the issues separate as that one pertains to Leaflet's controls).
The text was updated successfully, but these errors were encountered:
Successfully merging a pull request may close this issue.
It's recommended to use
<button>
instead of<a role="button">
. We should change the use of<a>
in all places we've introduced them:This would require a CSS reset to make buttons look seamless by default, e.g.:
(This generic button class was originally proposed in #263 (comment).)
Info on
<a>
vs<button>
:This issue relates to #19 (same problem but keeping the issues separate as that one pertains to Leaflet's controls).
The text was updated successfully, but these errors were encountered: