Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would it be useful to allow and enable more than one <extent units="..."> per layer #439

Closed
prushforth opened this issue Apr 28, 2021 · 6 comments · Fixed by #632
Closed
Assignees

Comments

@prushforth
Copy link
Member

One advantage might be that you could put several different projections in a single layer / mapml file and the client could pick the one that suits the map at the time.

Another possibility is that it could provide a scope for link templates and template variable names, which might help decrease error rates when editing them by hand / copying pasting+modifying (a standard coding method!).

Idea / question for discussion, pros and cons and so on.

@prushforth
Copy link
Member Author

Maybe the layer control could designate one summary/details per <extent>, so that you could turn on/off, and control the opacity of contents. Just a thought, there might be complications.

@ahmadayubi
Copy link
Member

I think the suggestion to have a separate summary for the different <link ref=",,,"> elements was made in the past too.

@prushforth
Copy link
Member Author

We should have a way to label an extent, which is clear for authors and implementers.

I suggest adding a label attribute to the extent element. If absent, the value would be inherited from the parent layer.

@Malvoz
Copy link
Member

Malvoz commented Oct 6, 2021

suggest adding a label attribute to the extent element.

Sounds reasonable.

If absent, the value would be inherited from the parent layer.

Not being able to differentiate between them seems problematic, there's a related issue in terms of what to do when a name/label hasn't been provided: #319.

@prushforth
Copy link
Member Author

@Malvoz a multiple-extent layer could provide access to the individual extents' settings via the settings button you proposed. Each child extent could be considered an individual "setting" of the parent, each with its own settings button that exposes the same settings structure below / inside it, (except there would be no more levels of settings - settings buttons, that is) , just the settings controls themselves i.e. opacity slider, check input, remove button, etc. (those could each be inside a details/summary, as you've shown). WDYT?

cc @Anshpreet8

@Malvoz
Copy link
Member

Malvoz commented Oct 6, 2021

Yes I think that'd form a logical structure.

those could each be inside a details/summary, as you've shown

I only kept details because that's what's currently used, I'm not completely sold on the idea that each setting (opacity/style/time) should in fact be wrapped in a details element.

@Anshpreet8 Anshpreet8 self-assigned this Oct 27, 2021
@Anshpreet8 Anshpreet8 mentioned this issue Dec 13, 2021
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants