Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Ctrl-Arrow decrease the pan increment #388

Closed
prushforth opened this issue Apr 11, 2021 · 6 comments · Fixed by #601
Closed

Allow Ctrl-Arrow decrease the pan increment #388

prushforth opened this issue Apr 11, 2021 · 6 comments · Fixed by #601

Comments

@prushforth
Copy link
Member

Make it easier to target smaller features using keyboard + graticule

@Malvoz
Copy link
Member

Malvoz commented Jul 13, 2021

2 observations:

  • I've been looking into gestures and keyboard controls recently, and it seems none of the UCR reference tools use the ctrl modifier key for anything, for some reason. So if pursuing this it might be worth investigating if that may be an issue.
  • AFAICT with Feature Indexing this would potentially not be necessary.

@prushforth prushforth added this to the Fall term 2021 milestone Jul 30, 2021
@ben-lu-uw
Copy link
Contributor

In the _onKeyDown function in Leaflet they return if the control key is pressed, not really sure why though.
image
Maybe cause Chrome has a ctrl + arrow shortcut set for moving tabs but it does not seem to work or do anything for me?

I did try adding this feature here https://github.com/ben-lu-uw/Web-Map-Custom-Element/tree/ctrl_pan and it seems to be issue free for me

@Malvoz
Copy link
Member

Malvoz commented Nov 25, 2021

Google Maps uses the shift modifier to decrease the pan increment, however Leaflet already uses that to increase it...

@prushforth
Copy link
Member Author

I tested powerpoint just now and ctrl-arrow doesn't appear to do anything different than just arrow by itself.
Shift-arrow increases the size of an object, and ctrl-shift-arrow also increases the size but reduces the size increment step.

Ctrl-scrollwheel or Ctrl-+/- changes the magnification of a domain in chrome.

Ctrl-arrow skips a word in most text editors, so increases the increment of cursor movement.

Let's dig a little more to see if there's anything arguing against using ctrl-arrow for decreased pan increments.

@Malvoz
Copy link
Member

Malvoz commented Nov 25, 2021

Let's dig a little more to see if there's anything arguing against using ctrl-arrow for decreased pan increments.

Ability to rotate map will need a modifier too.

@ben-lu-uw
Copy link
Contributor

Let's dig a little more to see if there's anything arguing against using ctrl-arrow for decreased pan increments.

Leaflet/Leaflet#2368

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants