Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is the fundamental D3 Geographies example doing too much, or too little? #204

Open
Malvoz opened this issue Mar 11, 2020 · 0 comments
Open
Labels
section: examples Discussion of the example pages

Comments

@Malvoz
Copy link
Member

Malvoz commented Mar 11, 2020

The D3 Geo example of creating a basic web map have added custom controls (zoom buttons) to the map viewer. That helps in making the web map "interactive", however since the API doesn't come with default controls to enable, I think it can be a good thing to showcase that not all tools do. Adding custom controls is otherwise better suited in the add-custom-control.html example.

Note that if you'd rather keep the zoom buttons: their accessible names are literally "+" and "-", not "Zoom in" and "Zoom out" respectively. Additionally, there's no way to pan the map using only the keyboard. Not sure if that is bothering anyone since these are "just" example pages, but I thought I'd point it out.

@Malvoz Malvoz added the section: examples Discussion of the example pages label Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
section: examples Discussion of the example pages
Projects
None yet
Development

No branches or pull requests

1 participant