Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance glass reflection (could probably affect perfomance) #356

Open
funn-hue opened this issue Jun 25, 2024 · 3 comments
Open

Enhance glass reflection (could probably affect perfomance) #356

funn-hue opened this issue Jun 25, 2024 · 3 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@funn-hue
Copy link

funn-hue commented Jun 25, 2024

Describe the bug

A clear and concise description of what the bug is:

The glass reflection is being applied to each window in Aero Peek, in Windows 7 it looks like there is just one image that only the frames can display. I know aero peek wasn't supposed to have the reflection in the first place (i might be wrong but i think one of you said it shouldn't render there), but fixing the issue could probably improve the app's perfomance by alot.

To Reproduce

Steps to reproduce the behavior:

  1. Open some apps
  2. Hover the "Show Desktop" button (make sure you have desktop peek on, you can check by right clicking the show desktop button)

Screenshots

If applicable, add screenshots to help explain your problem:

DWMBlurGlass
image

Windows 7
image

Additional information (please complete the following information):

OS Version : Windows 10 22H2 19045.4529
Software Version : 2.2.0

What other third-party software do you use:

[e.g. windhawk mods xxx]

AWM (issue persists without awm, so it's not related)

Additional context

Add any other context about the problem here.
By the way it would be nice if you guys added the reflections to aero snap aswell, since baking them into a theme is a really bad solution and causes visual glitches (see issue #221 )

@funn-hue funn-hue added the question Further information is requested label Jun 25, 2024
@ALTaleX531
Copy link
Collaborator

This is a workaround to bring reflection back to aero peek, and rendering multiple times behaves as expected. In fact, rendering multiple times produces less than a tenth of the performance overhead of the blur effect.

@funn-hue
Copy link
Author

funn-hue commented Jul 5, 2024

This is a workaround to bring reflection back to aero peek, and rendering multiple times behaves as expected. In fact, rendering multiple times produces less than a tenth of the performance overhead of the blur effect.

Why not do something like, render the reflection image once, make it fill the screen and make dwm put that into the taskbar and aero peek, and the other reflections would be on the windows?

@ALTaleX531
Copy link
Collaborator

Easier said than done, isn't it?

@ALTaleX531 ALTaleX531 changed the title Glass reflection bug (could probably affect perfomance) Enhance glass reflection (could probably affect perfomance) Jul 11, 2024
@ALTaleX531 ALTaleX531 added the enhancement New feature or request label Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants