Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Left border of maximized open/save dialogs #320

Open
aubymori opened this issue May 12, 2024 · 2 comments
Open

Left border of maximized open/save dialogs #320

aubymori opened this issue May 12, 2024 · 2 comments
Labels
Processed The issue has been resolved and is awaiting confirmation. question Further information is requested solved in upstream project This issue is already solved in the upstream project, just wait for the porting

Comments

@aubymori
Copy link

Describe the bug
The left border of maximized open/save dialogs does not have the glass effect applied and is entirely see-through. This happens due to the weird pseudo-maximized state* these windows are in.

To Reproduce

  1. Make sure DWMBlurGlass is enabled and you are using a theme which has visually thick borders (e.g. Aero Lite, any Windows 7 theme)
  2. Open any open/save dialog (e.g. File > Open in Notepad)
  3. If it isn't already, maximize the window by double clicking the titlebar
  4. You will see that the effect does not apply on the left border of the window

Screenshots
image

Additional information (please complete the following information):

OS Version : Windows 10 21H2 (19044.4291)
Software Version : 2.2.0

What other third-party software do you use:
None

Additional context
I have confirmed that this does not happen without DWMBlurGlass.

*This weird pseudo-maximized state has some attributes of maximized windows (e.g. caption icon and text offset being reduced) and doesn't have others (titlebar height reduction, borders off screen)

@aubymori aubymori added the question Further information is requested label May 12, 2024
@aubymori
Copy link
Author

Looks like this just happens to any window with the WS_MAXIMIZE style. This HTML help bug with hiding the sidebar is definitely the easiest to reproduce though.
image
Notepad with WS_MAXIMIZE manually added:
image

@ALTaleX531
Copy link
Collaborator

That's a good indication of the flaws in the current framework, but fortunately the new framework for the upstream project is perfectly fine.
Anyway, thanks for the feedback.
image

@ALTaleX531 ALTaleX531 added the solved in upstream project This issue is already solved in the upstream project, just wait for the porting label Jun 20, 2024
@Maplespe Maplespe added the Processed The issue has been resolved and is awaiting confirmation. label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Processed The issue has been resolved and is awaiting confirmation. question Further information is requested solved in upstream project This issue is already solved in the upstream project, just wait for the porting
Projects
None yet
Development

No branches or pull requests

3 participants