Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for questionable API use #39

Open
8 tasks
apasel422 opened this issue Aug 15, 2016 · 0 comments
Open
8 tasks

Add tests for questionable API use #39

apasel422 opened this issue Aug 15, 2016 · 0 comments

Comments

@apasel422
Copy link
Contributor

The following can and should panic:

  • Calling Gc::deref within force_collect
  • Calling Gc::clone within force_collect
  • Calling Gc::new within GcState::drop

The following would ideally panic, but might have to abort due to double panic, unspecified TLS drop order, or the inability to access TLS values during or after their destruction:

  • Calling Gc::deref within GcState::drop
  • Calling Gc::clone within GcState::drop
  • Calling Gc::new within GcState::drop

The following currently panic, but could also be made to work:

  • Calling force_collect within force_collect (would do nothing if nightly's RefCell::try_borrow_mut method indicates that a borrow is already outstanding)
  • Calling Gc::new within force_collect
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants