Split fbp from coil maps #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/CoilMaps.jl
Outdated
| Ndims = length(img_shape) | ||
| imdims = ntuple(i->i, Ndims) | ||
|
|
||
| xbp = calcFilteredBackProjection(data, trj, U, img_shape, Ncoils, density_compensation=density_compensation, verbose = verbose) |
There was a problem hiding this comment.
Little cosmetic change: I recently learned that the style guide suggests using a semicolon before the first keyword argument. Additionally, you can actually shorten the keyword argument calls if the argument and the argument's name are identical:
xbp = calcFilteredBackProjection(data, trj, U, img_shape, Ncoils; density_compensation, verbose)
In this case, the semicolon is required. Otherwise, it looks good!
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #31 +/- ##
==========================================
- Coverage 61.75% 60.63% -1.12%
==========================================
Files 5 5
Lines 217 221 +4
==========================================
Hits 134 134
- Misses 83 87 +4 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
separated the calculation of the filtered backprojection from calcCoilMaps functions and export the new function calcFilteredBackProjection.