Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working with Julia 1.8 #8

Open
jonschumacher opened this issue Dec 4, 2022 · 3 comments · May be fixed by MagneticParticleImaging/MPIReco.jl#19 or #9
Open

Not working with Julia 1.8 #8

jonschumacher opened this issue Dec 4, 2022 · 3 comments · May be fixed by MagneticParticleImaging/MPIReco.jl#19 or #9
Assignees
Labels

Comments

@jonschumacher
Copy link
Member

After years of not trying the data in this repo, I tried to run the examples with Julia 1.8 and the latest MPIReco as well as MPIReco down to 0.3.3, which seems to be the lowest version for Julia 1.8. The images look inverted. Do you have an idea what changes in MPIReco oder MPIFiles might cause these problems? Here is a picture of the reco1D.jl output:
grafik

@tknopp
Copy link
Member

tknopp commented Dec 5, 2022

I think we put a transfer function into the MDFs without using it at the time we created the repository. The default was later changed to always use the transfer function if it is available and probably that is the reason.

@tknopp
Copy link
Member

tknopp commented Dec 5, 2022

try setting tfCorrection = false as a reconstruction parameter.

@jonschumacher
Copy link
Member Author

I first tried to pass down the tf correction flag in MagneticParticleImaging/MPIReco.jl#19 but this did not change the output. rxHasTransferFunction(file) is false for both SM and measurement and thus the tfCorrection switch should already be false. The adapted scripts are in #9. Seems like this is not the issue. Do you have another idea what is going wrong?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants