Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invisible study created when switching protocol #51

Open
jusack opened this issue Apr 14, 2023 · 2 comments
Open

Invisible study created when switching protocol #51

jusack opened this issue Apr 14, 2023 · 2 comments

Comments

@jusack
Copy link
Collaborator

jusack commented Apr 14, 2023

Hi, when the protocol is changed in the GUI it seems like the currently selected study gets forgotten. The UI still shows the study as selected and in focus, but any new measurement after switching the protocol goes to a new study folder with the current datetime and blank name. This is a bit confusing since this blank study does not appear automatically in the study browser and the measurements don't show up in the original study, I found them by searching in the OS file explorer. Just pressing once again on the currently selected study does not switch back only selecting a different study and going back to the original one correctly selects the study again and new measurements will correctly appear.

@tknopp
Copy link
Member

tknopp commented Apr 25, 2023

Yes thanks for the bug report. I see basically two issues:

  1. As you mention, we need to take care that the selected study is preserved when switching protocols
  2. We somehow need to figure out ways to prevent that confusing studies are created. It's not the first time we see such issues.

@jusack
Copy link
Collaborator Author

jusack commented Oct 17, 2024

I fixed this in my branch JA/pmps in commit d14e44d
Initializing the ProtocolWidget now gets the currently selected study and we do not need to wait for a selection change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants