Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tubular regular positions #63

Merged
merged 10 commits into from
Sep 26, 2023
Merged

Conversation

jonschumacher
Copy link
Member

@jonschumacher jonschumacher commented Sep 25, 2023

For some kinds of simulations, it is sufficient to only simulate the physically possible positions. This is e.g. the case with circular scanner bores. This PR implements a regular grid constrained by a radius along one dimension resulting in a tubular fov.

@jonschumacher jonschumacher changed the title Tubular regular positions Draft: Tubular regular positions Sep 25, 2023
@jonschumacher jonschumacher changed the title Draft: Tubular regular positions Tubular regular positions Sep 25, 2023
@jonschumacher jonschumacher marked this pull request as draft September 25, 2023 15:06
@jonschumacher jonschumacher marked this pull request as ready for review September 26, 2023 07:47
@tknopp
Copy link
Member

tknopp commented Sep 26, 2023

This is very nice. I first read "tabular" and was somewhat confused...
I am really looking forward to see first reconstructions on such a grid.

@jonschumacher
Copy link
Member Author

jonschumacher commented Sep 26, 2023

I also want to try non-cartesian grids like a polar grid with a sun-like structure but that is something for the future because it involves more than a simple reshape ;)

@jonschumacher jonschumacher merged commit 044bb73 into master Sep 26, 2023
5 of 6 checks passed
@jonschumacher jonschumacher deleted the JS/tubular-regular-positions branch September 26, 2023 08:16
@jonschumacher jonschumacher restored the JS/tubular-regular-positions branch September 26, 2023 08:16
@jonschumacher jonschumacher deleted the JS/tubular-regular-positions branch September 26, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants