Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python 3.8 #2240

Open
afuetterer opened this issue Dec 9, 2024 · 2 comments · May be fixed by #2243
Open

Drop support for Python 3.8 #2240

afuetterer opened this issue Dec 9, 2024 · 2 comments · May be fixed by #2243

Comments

@afuetterer
Copy link
Contributor

Feature request

This is not really a feature request nor a bug report. It is in between.

Python 3.8 reached EOL in October. I suggest dropping it.

Motivation

See #1942 and https://devguide.python.org/versions

Your contribution

Would you like me to submit a PR?

@afuetterer
Copy link
Contributor Author

Also you will run into trouble, when dependencies only support 3.9+.

For example datamapplot is 3.9+ only.

@MaartenGr
Copy link
Owner

@afuetterer Thanks for sharing this! Fully agree, dropping support would be best as main dependencies are also dropping it (e.g., sentence-transformers). A PR would be appreciated!

@afuetterer afuetterer linked a pull request Dec 10, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants