Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plans to incorporate #9

Open
flokadillo opened this issue Nov 25, 2020 · 1 comment
Open

Plans to incorporate #9

flokadillo opened this issue Nov 25, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@flokadillo
Copy link

Thanks for publishing this interesting framework!
I have a question: Are you planning to support "real" python generators such as tf.Dataset as DataGenerator? Then the input pipeline could be much more efficient, especially when dealing with datasets that don't fit in memory.
Here is a nice blogpost about this: https://towardsdatascience.com/how-to-build-efficient-audio-data-pipelines-with-tensorflow-2-0-b3133474c3c1
Thanks and all the best!

@pzinemanas pzinemanas added the enhancement New feature or request label Nov 27, 2020
@pzinemanas
Copy link
Collaborator

Hi! Thanks for your question and comments.

First, it would be interesting to adapt the DataGenerator to work as a Python Generator. I'll read more about this.

Regarding your comment on data loading, it is clear that this process should be more efficient. This is an important issue to work on. We have to think how to do this, because the idea is to keep the library independent of the backend used to implement the machine learning model. Does it make sense to have different DataGenerators for each backend as we have with the ModelContainers? For instance, now we have KerasDataGenerator that converts a DataGenerator to be used for training keras models. Maybe we can implement this keras generator following the blog.

Perhaps @mrocamora, @pcancela-github or @ffont can comment about this.

@pzinemanas pzinemanas reopened this Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants