Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save feature extraction parameters to the model #8

Open
pzinemanas opened this issue Nov 5, 2020 · 0 comments
Open

Save feature extraction parameters to the model #8

pzinemanas opened this issue Nov 5, 2020 · 0 comments

Comments

@pzinemanas
Copy link
Collaborator

Models are designed for a specific set of feature extraction parameters. But, so far the parameters are only stored in the parameters.json file. So, we should save the parameters used for the design and training of the model.

This could be implemented by several ways, three options are:

  • Save a json file in the model folder. This is similar to how we save the parameters in the features folder.

  • Save the FeatureExtractor instance (pickle file) in the model folder. This method is perhaps more opaque to users, but it seems like a good solution.

  • A third option could be to save the ModelContainer instance in the model folder. To do this, we should include the FeatureExtractor instance in the ModelContainer. This change library usage, so we must discuss more about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant