Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Names of the functions to estimate rates and example in the documentation do not correspond #6

Open
liliana-calderon opened this issue Mar 30, 2023 · 1 comment

Comments

@liliana-calderon
Copy link

After a change in the name of the functions to estimate the rates, now called estimate_fertility_rates() and estimate_mortality_rates(),
when calling the R documentation, in the usage we get

estimate_fertility_rates(
opop,
final_sim_year,
year_min,
year_max,
year_group = 5,
age_min_fert = 15,
age_max_fert = 50,
age_group = 5
)

But in the example:

Retrieve age-specific fertility rates

asfr <- get_asfr_socsim(opop = opop,
final_sim_year = 2021,
year_min = 1750,
year_max = 2020,
year_group = 5,
age_min_fert = 10,
age_max_fert = 55,
age_group = 5)

It should be better to unify the terms: estimate instead of retrieve and get.
In the explanation of the arguments, age_min_fert has the explanation for age_max_fert (numeric. Upper-bound age of female reproductive period) It should be Lower-bound. Also, age_max_fert is missing.

In the case of mortality, we have the same problem:

In the usage, it uses the term estimate
estimate_mortality_rates(
opop,
final_sim_year,
year_min,
year_max,
year_group,
age_max_mort,
age_group
)

But in the example it shows Retrieve and get

Retrieve age-specific mortality rates

asmr <- get_asmr_socsim(opop = opop,
final_sim_year = 2021,
year_min = 1750,
year_max = 2020,
year_group = 5,
age_max_mort = 110,
age_group = 5)

@tomthe
Copy link
Member

tomthe commented Mar 30, 2023

Okay, I agree. So I will change this all to estimate_mortality_rates and estimate_fertility_rates where appropriate. retrieve_kin will remain retrieve_kin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants