fix(annotations): use postponed evaluation #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpbonelli
force-pushed
the
annotations
branch
from
5bf0daf to
f36d8b6
Compare
|
process-scripts.py needs py39+ to use ast.unparse. Or the ast-compat backport for older versions. |
wpbonelli
force-pushed
the
annotations
branch
from
f36d8b6 to
a4c03ec
Compare
* 6899ae1 switched list[... to List[... for compat with python 3.8 * instead opt into postponed evaluation per suggestion * use matrix to CI test python 3.8 - 3.11
wpbonelli
force-pushed
the
annotations
branch
from
a4c03ec to
5db6db4
Compare
|
thanks @mwtoews, can't request review but please advise if anything looks amiss |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
list[...variable annotations toList[...for python 3.8 compatibility