Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DEV-2013] V4 updates #16

Merged
merged 20 commits into from
Nov 15, 2024
Merged

[DEV-2013] V4 updates #16

merged 20 commits into from
Nov 15, 2024

Commits on Nov 10, 2024

  1. Update to MLH API v4 

    - Update endpoints to use v4 API
- Add support for expandable fields
- Update scopes to use new granular system
- Configure auth params to use request body
- Document offline_access scope for refresh tokens
    @devin-ai-integration
    devin-ai-integration[bot] committed Nov 10, 2024
    Configuration menu
    Copy the full SHA
    32eba81 View commit details
    Browse the repository at this point in the history

  2. Update to MLH API v4 

    - Update endpoints to use v4 API
- Add support for expandable fields
- Update scopes to use new granular system
- Configure auth params to use request body
- Document offline_access scope for refresh tokens
- Add deep symbolization for nested arrays
- Include all fields from user object schema
    @devin-ai-integration
    devin-ai-integration[bot] committed Nov 10, 2024
    Configuration menu
    Copy the full SHA
    b2cc0c0 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2024

  1. test: Add comprehensive test coverage for v4 API 

    - Added ActiveSupport for deep symbolization
- Updated test structure for v4 API compatibility
- Improved SimpleCov configuration
- Increased line coverage to 80.49%
- Added branch coverage tracking

Link to Devin run: https://preview.devin.ai/devin/3be39d31a19840d9ae7b7bebabe8c9c6
    @devin-ai-integration
    devin-ai-integration[bot] committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    028b150 View commit details
    Browse the repository at this point in the history

  2. test: Increase test coverage from 80.49% to 87.8% 

    - Add tests for complex nested arrays and hashes
- Add tests for hash pruning with nil values
- Add tests for completely empty hashes
- Add tests for version constant and module loading
- Add explicit tests for uid method
- Fix spec_helper.rb to properly load all files
    @devin-ai-integration
    devin-ai-integration[bot] committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    06b884b View commit details
    Browse the repository at this point in the history

  3. Replace subject with strategy in tests to fix RSpec/NamedSubject viol… 

    …ations
    @devin-ai-integration
    devin-ai-integration[bot] committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    2ef82c8 View commit details
    Browse the repository at this point in the history

  4. Apply RuboCop auto-corrections for code style improvements

    @devin-ai-integration
    devin-ai-integration[bot] committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    aefa98f View commit details
    Browse the repository at this point in the history

  5. Fix RuboCop offenses and improve test infrastructure 

    - Refactored MLH strategy for better code organization
- Fixed hash indentation in shared examples
- Replaced unverified doubles with instance_double
- Moved spec files to correct directory structure
- All tests passing with 88.64% line coverage
    @devin-ai-integration
    devin-ai-integration[bot] committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    f100f57 View commit details
    Browse the repository at this point in the history

  6. We don't need to support Ruby 2.7

    @jonmarkgo
    jonmarkgo authored Nov 11, 2024
    Configuration menu
    Copy the full SHA
    a9f91f1 View commit details
    Browse the repository at this point in the history

  7. Update gem version to 2.0

    @jonmarkgo
    jonmarkgo committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    15ae467 View commit details
    Browse the repository at this point in the history

  8. Correct json parsing

    @jonmarkgo
    jonmarkgo committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    e0d5b61 View commit details
    Browse the repository at this point in the history

  9. fix: properly handle data wrapper in API response and update test inf… 

    …rastructure
    @devin-ai-integration
    devin-ai-integration[bot] committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    6cafa4e View commit details
    Browse the repository at this point in the history

  10. Revert "fix: properly handle data wrapper in API response and update … 

    …test infrastructure"

This reverts commit 6cafa4e.
    @devin-ai-integration
    devin-ai-integration[bot] committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    90dae4c View commit details
    Browse the repository at this point in the history

  11. fix: update test doubles to match strategy implementation

    @devin-ai-integration
    devin-ai-integration[bot] committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    09c4f58 View commit details
    Browse the repository at this point in the history

  12. style: fix argument alignment in spec file

    @devin-ai-integration
    devin-ai-integration[bot] committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    95ef066 View commit details
    Browse the repository at this point in the history

  13. rubocop formatting

    @jonmarkgo
    jonmarkgo committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    7a21ff5 View commit details
    Browse the repository at this point in the history

  14. add line breaks as per Rashika's request

    @jonmarkgo
    jonmarkgo committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    1179c47 View commit details
    Browse the repository at this point in the history

  15. Change the style as per Rashika's request in MLH#16 (comment)

    @jonmarkgo
    jonmarkgo committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    72c6281 View commit details
    Browse the repository at this point in the history

  16. Update the README for v4

    @jonmarkgo
    jonmarkgo committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    d4c26a8 View commit details
    Browse the repository at this point in the history

  17. add example for accessing user data

    @jonmarkgo
    jonmarkgo committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    d2cf29f View commit details
    Browse the repository at this point in the history

  18. README formatting fix

    @jonmarkgo
    jonmarkgo committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    39295df View commit details
    Browse the repository at this point in the history