Upgrade Strategy to MyMLH v4 API #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update API endpoints to use v4 - Add new granular scope system - Remove support for Implicit Grant flow - Update documentation with breaking changes - Add migration guide for v2.0.0 - Update examples with new scope format
- Add activesupport for deep_symbolize_keys functionality - Update test data structure to match v4 API response format - Fix hash key transformation in tests to handle nested structures - Add more comprehensive test data coverage
- Remove extra spacing in comments - Use verified doubles in specs - Improve test structure to avoid subject stubbing - Use instance_variable_set for access token in tests
- Update API endpoints to use v4 - Add new granular scope system - Update token exchange to use basic auth - Remove Implicit Grant flow support - Update documentation with breaking changes - Add migration guide for v2.0.0 - Update examples with new scope format Breaking Changes: - API endpoint changed to api.mlh.com - New scope format required - Implicit Grant flow removed - Version bumped to 2.0.0
- Remove vendor directory from git tracking - Add vendor/ to .gitignore to prevent future tracking - Keep dependencies managed through Bundler only
- Added expired? method to token mock - Added API response mock for user data - Added proper Rack app context for OmniAuth strategy - Achieved 100% test coverage
- Remove deprecated test_files from gemspec - Fix argument alignment in spec file - Configure new RuboCop cops - Update RSpec test structure
|
Working MyMLH v3 example: https://gist.github.com/jonmarkgo/1881ab9da877de26c4b1a267350690d8/revisions#diff-f965f92b425fb2f75d38b491b2625fe21b8af20b7666217546bce8a42b198ea4 Working MyMLH v4 example: https://gist.github.com/jonmarkgo/1881ab9da877de26c4b1a267350690d8/revisions#diff-9ad32be17347f0cdcc9a38ac9af49d418554f067f3aac5885cf9bddfcee0556f Note that for the v4 example, I have a tmp branch of this PR that changes the URL to beta.my.mlh.io rather than my.mlh.io |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to MyMLH API v4
This PR updates the omniauth-mlh gem to use the MyMLH API v4 endpoints and introduces several breaking changes that warrant a version bump to 2.0.0.
Changes
Breaking Changes
New API Endpoints
Updated Scope System
Authentication Flow
Test Suite Improvements
activesupportas a development dependency to supportdeep_symbolize_keysfunctionalityTesting
Link to Devin runs: