Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MISP Env OIDC_ENABLE=true #158

Closed
Diogo-Rego opened this issue Oct 2, 2024 · 6 comments · Fixed by #161
Closed

MISP Env OIDC_ENABLE=true #158

Diogo-Rego opened this issue Oct 2, 2024 · 6 comments · Fixed by #161
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@Diogo-Rego
Copy link
Contributor

MISP Env OIDC_ENABLE=true not working correctly, where when doing OIDC_ENABLE=true and then OIDC_ENABLE=false it still remains with OIDC_ENABLE=true
@ostefano
Copy link
Collaborator

ostefano commented Oct 2, 2024

I am not surprised by this, I see rarely testing flipping on/off a new functionality.

For the time being, just remove the config.php file and let the container recreate it.

Obviously I would totally welcome PRs fixing this specific behavior.

@ostefano ostefano added bug Something isn't working good first issue Good for newcomers labels Oct 2, 2024
@Diogo-Rego
Copy link
Contributor Author

Diogo-Rego commented Oct 2, 2024 •
edited
Loading

@ostefano
Can we accept this PR #148 now so I can fix this bug?

@ostefano
Copy link
Collaborator

ostefano commented Oct 2, 2024

@Diogo-Rego done

@Diogo-Rego
Copy link
Contributor Author

@ostefano confirm this PR #161

@ostefano
Copy link
Collaborator

ostefano commented Oct 2, 2024

Added comment

@Diogo-Rego
Copy link
Contributor Author

Added comment

@ostefano confirm again

@ostefano ostefano linked a pull request Oct 2, 2024 that will close this issue
Fix OIDC_ENABLE Toggle Logic in MISP Environment Configuration #161
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix OIDC_ENABLE Toggle Logic in MISP Environment Configuration Diogo-Rego/misp-docker
2 participants
@ostefano @Diogo-Rego