Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests #17

Open
MGough opened this issue May 6, 2020 · 2 comments · May be fixed by #18
Open

Add unit tests #17

MGough opened this issue May 6, 2020 · 2 comments · May be fixed by #18
Assignees
Labels
enhancement New feature or request

Comments

@MGough
Copy link
Owner

MGough commented May 6, 2020

The flask services need unit tests! Will be run using tox.

@MGough MGough added the enhancement New feature or request label May 6, 2020
@MGough MGough self-assigned this May 6, 2020
@MGough
Copy link
Owner Author

MGough commented May 12, 2020

Having recently worked on projects which have areas of the codebase that border on 'Mock hell' (due to testing taking too much priority over refactoring) I'm still thinking of how best to approach this for the tests which interact with SQLAlchemy

@MGough
Copy link
Owner Author

MGough commented May 12, 2020

I began to develop a layer between the objects and the SQLAlchemy calls, which seems to closely reflect this: https://www.cosmicpython.com/book/chapter_04_service_layer.html#_introducing_a_service_layer_and_using_fakerepository_to_unit_test_it

I'll read through more of this and at some point I'll probably continue and implement it in this way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant