Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PETSCII instead of ASCIIKEY #603

Open
Pimau opened this issue Aug 14, 2024 · 4 comments
Open

PETSCII instead of ASCIIKEY #603

Pimau opened this issue Aug 14, 2024 · 4 comments
Labels
new New report, not classified yet

Comments

@Pimau
Copy link

Pimau commented Aug 14, 2024

Describe where we can find the problematic topic
On page I-76, VECTOR, vector table, 4th paragraph.

Describe the solution you'd like
CTLVEC, SHFVEC, and ESCVEC are describing to deliver "unmodified PETSCII code" in the accumulator. Shouldn't that be the ASCIIKEY (which is described in "USING THE TYPING EVENT QUEUE" on F-3)?
I think the PETSCII in A is only true for KEYSCAN.

@Pimau Pimau added the new New report, not classified yet label Aug 14, 2024
@dansanderson
Copy link
Collaborator

The documentation is correct. Is there a reason why you believe it to be incorrect?

These vectors are deep inside the screen editor, which processes PETSCII codes. These codes can be printed as well as typed.

@Pimau
Copy link
Author

Pimau commented Aug 19, 2024

Hi! When I use the three functions, I get the values back which are listed in the tables on F-5ff. The introduction to this tables speak of ASCII, not PETSCII. And for instance A is noted with 61 not 01 when pressed alone, 41 with Shift.
But in the meantime I also implemented KEYSCAN and this is also delivering the contents of table F5 „Keys pressed alone“. So my above assumption that KEYSCAN delivers PETSCII is wrong.

@Pimau
Copy link
Author

Pimau commented Aug 19, 2024

When I think about it, it is not PETSCII and not ASCII, more somthing like a machine related key scanner code, isn‘t it?

@dansanderson
Copy link
Collaborator

Ah hm, ok. The ROM's own handlers really made it look like it was expecting key codes to already have been translated to PETSCII. I'll do my own test and update the docs. Thanks for the report!

@dansanderson dansanderson reopened this Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new New report, not classified yet
Projects
None yet
Development

No branches or pull requests

2 participants