Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text overflows without notice in many windows #359

Open
mirh opened this issue Feb 9, 2023 · 2 comments
Open

Text overflows without notice in many windows #359

mirh opened this issue Feb 9, 2023 · 2 comments

Comments

@mirh
Copy link

mirh commented Feb 9, 2023

Describe the bug
I was writing a noob-proof tutorial on doing a thing with legendaryexplorer, when I noticed that the hex view of the binary interpreter is not aligned to the whole content of the "panel", but just the hex values.
Now, I didn't think too much about it, but then I noticed that the "Find references" window is also totally careless about the content of the dialog.

Expected behavior
Reflow like happens here and there, or at least place a scrollbar?

Screenshots and files used to replicate this

Version information:
v6.3.0.5098

Other information
It's not exactly this UI pedantry is a big deal per se, but I could totally see somebody doing mistakes because the window cuts exactly in a point that would give you clue whatsover as to whether there was "more text".

@Mgamerz
Copy link
Member

Mgamerz commented Feb 10, 2023

The dialog is a generic one we used called ListDialog. It shouldn't be too much work to add a horizontal scrollbar. As for the hex, I'm not sure why yours looks like that, as it isn't supposed to show the right side content at all unless you expand, but the hexbox is its own thing in the toolset that is best left alone.

This seems like a reasonable request; not entirely sure when we will get to it, but it seems like a worthwhile QOL feature.

As for your tutorial, it seems like you could just either post the already-patched files, or make a mod that overrides them, it would be much easier for users.

On your wiki page, you say In most cases the problem is caused by incompatibility with the video or audio drivers of the user's computer.[citation needed], but in the original thread this fix was found on (I read through it), there is no mention whatsoever of this. I don't know of any evidence that would support this claim.

@mirh
Copy link
Author

mirh commented Feb 11, 2023

I'm not sure why yours looks like that, as it isn't supposed to show the right side content at all unless you expand

I did do that, yes. To show how conspicuous the "cut" is.
Then, I see how that was actually intentional now (and if you don't know that there should be other information, I guess yeah that's not the tool for you).. but still.
Or actually, I'm wondering why this default is even the case? It's not like even your average modder wouldn't still need it.

I don't know of any evidence that would support this claim.

I don't know either, yet an user put it back even after I deleted it (and I didn't really want to bang my head further).
Moreover, even though I believe we know it has something to do with caching, AFAIK it's yet to be determined why supposedly it doesn't always happen 100% of times either.

or make a mod that overrides them, it would be much easier for users.

To be absolutely honest, it's a bit funny how somewhat comparable (if not quicker perhaps if you already knew the tools?) this "manual procedure" would be compared to having to download a file through nexusmod.
Though yeah, a mod would be ideal (and it would also avoid having to handwave the "different localizations" part).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants