Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port over the get_cmap fix from mdakit-hole2 #4338

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Port over the get_cmap fix from mdakit-hole2 #4338

merged 1 commit into from
Nov 8, 2023

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Nov 5, 2023

See: https://github.com/MDAnalysis/hole2-mdakit/pull/39/files

We might need to consider if removing hole2 and just optionally importing hole2-mdakit might be a good idea eventually.

Developers certificate of origin


📚 Documentation preview 📚: https://mdanalysis--4338.org.readthedocs.build/en/4338/

Copy link

github-actions bot commented Nov 5, 2023

Linter Bot Results:

Hi @IAlibay! Thanks for making this PR. We linted your code and found the following:

There are currently no issues detected! 🎉

Copy link

codecov bot commented Nov 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cb26ebc) 93.37% compared to head (8c2c072) 93.37%.
Report is 3 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##           develop    #4338     +/-   ##
==========================================
  Coverage    93.37%   93.37%             
==========================================
  Files          170      184     +14     
  Lines        22299    23407   +1108     
  Branches      4075     4075             
==========================================
+ Hits         20822    21857   +1035     
- Misses         962     1035     +73     
  Partials       515      515             
Files Coverage Δ
package/MDAnalysis/analysis/hole2/hole.py 83.07% <100.00%> (ø)

... and 14 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@RMeli RMeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @IAlibay

@RMeli RMeli merged commit cfe2516 into develop Nov 8, 2023
26 checks passed
@RMeli RMeli deleted the hole2-cmap branch November 8, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants