Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update style docs for list parameters #181

Open
PicoCentauri opened this issue Jan 2, 2022 · 6 comments
Open

Update style docs for list parameters #181

PicoCentauri opened this issue Jan 2, 2022 · 6 comments

Comments

@PicoCentauri
Copy link

PR #3482 in the main repo changed the style of parameter docs for lists. Parameters are tagged following the type hints notation of Python i.e. list[int]. This should be consistently followed in the repo.

@lilyminium
Copy link
Member

This fix should either add a new section in the user guide, or check if there's an existing section on documentation style and edit it.

@robotjellyzone
Copy link

robotjellyzone commented Apr 10, 2022

Hi , I would like to take this up. Is there any other guide I first need to follow for this task or anything i need to know before start working on this @lilyminium @PicoCentauri ? also, do i need to assigned to this task in order to contribute for this task?

@PicoCentauri
Copy link
Author

@robotjellyzone, no need to assign you here. If you say you work in this everybody knows :)

I suggest adding details on the style in the section about guidelines for writing docstrings.

@robotjellyzone
Copy link

robotjellyzone commented Apr 12, 2022

@robotjellyzone, no need to assign you here. If you say you work in this everybody knows :)

I suggest adding details on the style in the section about guidelines for writing docstrings.

@PicoCentauri can you please elaborate more regarding which section needs to be changed and exactly what I need to change?

@PicoCentauri
Copy link
Author

First off all you could add another example in the code example

def func(arg1, arg2, arg3):
    """Summary line.

    Extended description of function.

    Parameters
    ----------
    arg1 : int
        Description of `arg1`
    arg2 : str
        Description of `arg2`
    arg2 : list[str]
        Description of `arg2`

And add a something like in lines of.

The parameter and attribute types should follow type hint recommendations.

@robotjellyzone
Copy link

i am done with the changes. can you please once check @PicoCentauri @lilyminium pr #200

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants