Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customisable banner via HTML & CSS #2

Open
PiggyPiglet opened this issue Dec 22, 2019 · 2 comments
Open

Customisable banner via HTML & CSS #2

PiggyPiglet opened this issue Dec 22, 2019 · 2 comments
Labels
enhancement New feature or request investigate
Milestone

Comments

@PiggyPiglet
Copy link

PiggyPiglet commented Dec 22, 2019

I propose a system where a user could provide a custom template & styling via HTML & CSS, with variables such as {{downloads}}, {{favicon}}, {{name}}, etc. By default, a preset would be automatically selected, but this option is there for those who wish to customise. The data could be stored via a user system, where banners and their meta data are linked to a specific user, and therefore could be changed at a later date without the image url changing. Alternatively, banners could be anonymous with the meta data is stored exclusively with the banner, and not linked to anything else - effectively immutable.

https://github.com/radkovo/WebVector

@PiggyPiglet PiggyPiglet changed the title Customisable banner styling via HTML & CSS Customisable banner via HTML & CSS Dec 22, 2019
@jacobsandersen
Copy link
Collaborator

Thanks for your suggestion. We have a user system planned, but we haven't quite gotten to that point yet. This system is still fairly alpha. We'll consider the templating suggestion, but I worry that allowing full HTML & CSS would create a number of attack vectors. It'd have to be a heavy subset, or alternatively Markdown or something with styling controlled in some other way.

I agree that the URL changing with every customization option is gross -- this will be changed once we implement our user account system.

@jacobsandersen jacobsandersen added the enhancement New feature or request label Dec 30, 2019
@jacobsandersen
Copy link
Collaborator

Just took a look at WebVector and it seems worthy of further research. Thanks for this link.

@jacobsandersen jacobsandersen added this to the soon milestone Jan 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request investigate
Projects
None yet
Development

No branches or pull requests

2 participants