Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider fluorescence_traces_dff timestamp handling #92

Closed
vijayiyer05 opened this issue Apr 12, 2021 · 2 comments
Closed

Consider fluorescence_traces_dff timestamp handling #92

vijayiyer05 opened this issue Apr 12, 2021 · 2 comments

Comments

@vijayiyer05
Copy link
Collaborator

Ophys session properties are now uniformly accessed as a single value output.

Since the found implementation of the fluorescence_traces_dff property was explicitly determining both the timestamps and the traces (via two separate h5 reads), these are packed into a compound structure type. This requires the end user to unpack.

@DylanMuir: Is there a reason you can recall why fluorescence_traces_dff explicitly reads its H5 timestamps rather than simply re-using the fluorescence_timestamps vector as done with the other fluorescence_traces properties (e.g. demixed)? Or better put: do you expect the DFF timestamps could ever differ from the fluorescence timestamps. So far the dff timestamps and original fluorescence timestamps always seem identical. If we always expect this, we could simplify the user interface (while adding a check/confirmation if it seems wise).

@DylanMuir
Copy link
Collaborator

I can't recall an explicit reason, and it would be surprising for the DFF timestamps to differ from the other fluorescence signal timestamps.

@vijayiyer05
Copy link
Collaborator Author

Now part of #95

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants