You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Ophys session properties are now uniformly accessed as a single value output.
Since the found implementation of the fluorescence_traces_dff property was explicitly determining both the timestamps and the traces (via two separate h5 reads), these are packed into a compound structure type. This requires the end user to unpack.
@DylanMuir: Is there a reason you can recall why fluorescence_traces_dff explicitly reads its H5 timestamps rather than simply re-using the fluorescence_timestamps vector as done with the other fluorescence_traces properties (e.g. demixed)? Or better put: do you expect the DFF timestamps could ever differ from the fluorescence timestamps. So far the dff timestamps and original fluorescence timestamps always seem identical. If we always expect this, we could simplify the user interface (while adding a check/confirmation if it seems wise).
The text was updated successfully, but these errors were encountered:
Ophys session properties are now uniformly accessed as a single value output.
Since the found implementation of the fluorescence_traces_dff property was explicitly determining both the timestamps and the traces (via two separate h5 reads), these are packed into a compound structure type. This requires the end user to unpack.
@DylanMuir: Is there a reason you can recall why fluorescence_traces_dff explicitly reads its H5 timestamps rather than simply re-using the fluorescence_timestamps vector as done with the other fluorescence_traces properties (e.g. demixed)? Or better put: do you expect the DFF timestamps could ever differ from the fluorescence timestamps. So far the dff timestamps and original fluorescence timestamps always seem identical. If we always expect this, we could simplify the user interface (while adding a check/confirmation if it seems wise).
The text was updated successfully, but these errors were encountered: