Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LinkedFiles Enhancements #134

Open
2 tasks
vijayiyer05 opened this issue Oct 3, 2021 · 2 comments
Open
2 tasks

LinkedFiles Enhancements #134

vijayiyer05 opened this issue Oct 3, 2021 · 2 comments

Comments

@vijayiyer05
Copy link
Collaborator

vijayiyer05 commented Oct 3, 2021

  • Apparent bug with StimTemplatesGroup entry for ephys sessions: table row in the linkedFiles property is not populating even after accessing relevant properties
  • Consider two column format with filename as first column and path as second column, to improve display utility
@vijayiyer05
Copy link
Collaborator Author

@ehennestad Have moved this to deferred; it's not too essential for 0.9.3

High-level notes for the future:

  • A near-term simplification could be for linkedFiles property to simply consist of the auto-download

Nitty-gritty notes for the future:

  • I think we want the linkedFiles property to re-display a portion of the info in the hidden linkedFilesInfo table user knows what files are available & has a nickname to access anything that's not auto-downloaded
  • Assuming above, there should also be a method for retrieving (download or copy, per the preferences) specified nicknamed files or the whole group; this action would update the linkedFiles property to reflect the cached file location
  • For ophys, we shoudl track down what the SessH5 file is, or remove it if defunct
  • For the stim_templates property, I think we want to make it smarter to be primarily indexed by movie & scene & then point to path & link for each; probably better as a struct with movie & scene dictionary fields
  • For mounted/cloud use case, should ideally ensure linkedFiles showed all files up front since no download is needed

@ehennestad
Copy link
Collaborator

Comments on some of the above points:

For ophys, we shoudl track down what the SessH5 file is, or remove it if defunct

I think this contains results of analysis of data, but I don't know the specifics.

For the stim_templates property, I think we want to make it smarter to be primarily indexed by movie & scene & then point to path & link for each; probably better as a struct with movie & scene dictionary fields

As discussed before, the stim templates are shared among all the ephys sessions, and are independent of individual sessions, so it might make sense to make a StimulusTemplate class which is a subclass of Item or LinkedFilesItem or even a LinkedFilesItemGroup.

Implementation-wise, it got a bit ugly to include it in the EphysSession class, especially with regards to download of the individual files.

For mounted/cloud use case, should ideally ensure linkedFiles showed all files up front since no download is needed

This should now be very easy to do, since all the relevant item classes have methods for constructing the full file path

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants