Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new UI command to set desired country for ExitService #468

Open
czarte opened this issue Aug 9, 2024 · 5 comments
Open

Create new UI command to set desired country for ExitService #468

czarte opened this issue Aug 9, 2024 · 5 comments
Assignees

Comments

@czarte
Copy link
Collaborator

czarte commented Aug 9, 2024

This command send to Node country_code of desired ExitService location.

masq/src/commands/set_configuration_command.rs
.arg(set_configurationify(exit_location_arg())) to set_configuration_subcommand.

@dnwiebe
Copy link
Collaborator

dnwiebe commented Aug 9, 2024

I would like to see this command designed so that instead of setting just one desired country, the user can specify a list of them, any one of which would be acceptable. I would also like to see the command designed so that in the future it can be used to specify named country groups (which we don't yet have) with a minimum of effort.

@kauri-hero kauri-hero transferred this issue from MASQ-Project/MASQ-Node-issues Aug 10, 2024
@dnwiebe
Copy link
Collaborator

dnwiebe commented Aug 11, 2024

I would also like to see this setting made part of the CONFIG table, and included in the set-configuration command so that it can be set at runtime. Maybe also a new command-line parameter to make it accessible to config.toml files.

@dnwiebe
Copy link
Collaborator

dnwiebe commented Aug 11, 2024

Sense from the Sunday meeting is that the Free World Bit and this desired-country-list mechanism should not be allowed to operate at the same time, because they'll interfere with each other. At least one of us has opined that the Free World Bit should be abandoned entirely.

@czarte
Copy link
Collaborator Author

czarte commented Aug 12, 2024

The JSON from UI will be formated as follows:

priority is ordering information. 0 highest and n lowest

{
  "fallback_routing": false,
  "country_codes": [
    {
      "country_codes": ["CZ", ...],
      "priority": 0,
    },
    {
      "country_codes": ["SK", ...],
      "priority": 1,
    }.
    {
      "country_codes": ["PL", ...],
      "priority": 2,
    }
  ]
}

@czarte
Copy link
Collaborator Author

czarte commented Oct 29, 2024

waiting for #545

czarte added a commit that referenced this issue Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏗 Development In Progress
Development

No branches or pull requests

2 participants