Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defend against evil UI connections #815

Open
dnwiebe opened this issue Nov 7, 2024 · 0 comments
Open

Defend against evil UI connections #815

dnwiebe opened this issue Nov 7, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@dnwiebe
Copy link

dnwiebe commented Nov 7, 2024

We believe that it might be possible for an evil originating Node to construct a CORES package with a server name of "localhost" or 127.0.0.1 or 0.0.0.0 that might persuade an exit Node's ProxyServer to make a UI connection to its own WebSocketSupervisor and allow the evil originating Node to control the exit Node.

The ProxyClient should be modified so that it rejects any CORES package with a URL containing "localhost", "127.0.0.1", "0.0.0.0", or any other reference to the local machine. When malefactor banning comes on board, this should result in a malefactor ban by wallet of the source.

Also, modify the ProxyServer so that no CORES package can be created, even accidentally, with those hostnames; that way, the ProxyClient can be confident that any originating Node that sends such a CORES package really is a malefactor.

Check out the code and see if it's appropriate to also trigger on the IPv6 versions of those addresses.

@dnwiebe dnwiebe converted this from a draft issue Nov 7, 2024
@kauri-hero kauri-hero added the bug Something isn't working label Nov 10, 2024
@kauri-hero kauri-hero moved this from 🆕 New to 🔖 Awaiting Development (Prioritized) in MASQ Node v2 Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 🔖 Awaiting Development (Prioritized)
Development

No branches or pull requests

2 participants