Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add_findings_bundle example #81

Open
abulhol opened this issue Nov 4, 2015 · 2 comments
Open

add_findings_bundle example #81

abulhol opened this issue Nov 4, 2015 · 2 comments

Comments

@abulhol
Copy link

abulhol commented Nov 4, 2015

I noticed this

# Add the Bundle to the Malware Subject
subject.add_findings_bundle(bundle)
subject.findings_bundles.bundle = [bundle]

in
https://github.com/MAECProject/python-maec/blob/master/examples/package_generation_example.py

What is the purpose of the second instruction? It does not seem to have any effect.
I am just trying to get a good understanding how to create a MAEC file.

@ikiril01
Copy link
Member

ikiril01 commented Nov 4, 2015

Ah, good catch. You're right - the second subject.findings_bundles.bundle = [bundle] instruction is unnecessary and likely leftover from some legacy code.

@abulhol abulhol closed this as completed Nov 4, 2015
@gtback gtback self-assigned this Aug 11, 2016
@gtback
Copy link
Contributor

gtback commented Aug 11, 2016

We should still fix this, but it's a low priority.

@gtback gtback reopened this Aug 11, 2016
@gtback gtback removed their assignment Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants