Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

park details modal tested #70

Merged
merged 2 commits into from
Mar 1, 2024
Merged

park details modal tested #70

merged 2 commits into from
Mar 1, 2024

Conversation

Jesuitman
Copy link
Contributor

@Jesuitman Jesuitman commented Mar 1, 2024 •
edited by tenthwalker
Loading

What I did: added in testing for the details page
Did this break anything?

  • No
  • Yes
    Type of change
  • New feature (non-breaking change which adds functionality)
  • Styling
  • Bug fix (non-breaking change which fixes an issue)
  • Refactor(DRY-ing up/ reorganizing code, etc.)
  • Super small fix (Corrected a typo, removed a comment, etc.)
  • Skip all the other stuff and briefly explain the fix.
    Checklist:
  • If this code needs to be tested, all tests are passing
  • The code runs locally
  • There are comments where clarification/ organization is needed
  • The code is DRY. If it's not, I tried my best
  • I reviewed my code before pushing
    What's next?

@vercel Vercel
Copy link

vercel bot commented Mar 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
m4-parks-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 1, 2024 7:58pm
m4-parks-frontend-omq5 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 1, 2024 7:58pm

tenthwalker
tenthwalker approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@tenthwalker tenthwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting these knocked out, it's been really cool to see the modal process and implementation.

cypress/e2e/spec.cy.js
cy.intercept('GET', "https://m4-parks-backend.onrender.com/api/v0/weather/abli", {
fixture: 'abli-weather.json'
})
.as("getAbliWeather")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating these, I felt like I must've missed a step and this was it.

... URL testing -- Should take you back to the main page when you put a bad URL in (failed).png Outdated Show resolved Hide resolved
@tenthwalker tenthwalker merged commit 49d6253 into main Mar 1, 2024
3 checks passed
@tenthwalker tenthwalker linked an issue Mar 1, 2024 that may be closed by this pull request
Update cypress tests: park details page modals #65
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tenthwalker tenthwalker tenthwalker approved these changes

@JoeyStewart JoeyStewart Awaiting requested review from JoeyStewart

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update cypress tests: park details page modals
2 participants
@Jesuitman @tenthwalker