Add copy to clipboard button in Diagnostics page. #2717
+50
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ildyria
added
the
Review: easy
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
|
tinohager
reviewed
Nov 20, 2024
| const canCopy = computed(() => errorLoaded.value && infoLoaded.value && configurationLoaded.value); | ||
|
|
||
| function copy() { | ||
| const errors = document.getElementById("ErrorsData"); |
There was a problem hiding this comment.
Whoa, that's definitely not the way to do it! 💩
it is possible to transmit the data to the outside via the emit
https://vuejs.org/guide/typescript/composition-api#typing-component-emits
There was a problem hiding this comment.
I know, but I didn't feel like it. 😆
And that was simpler to "copy" the content that way.
There was a problem hiding this comment.
That's still not the way to do it. The other is more standardized 😄
d7415
approved these changes
Nov 20, 2024
Co-authored-by: Martin Stone <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.