Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualiser slows down significantly over time #4

Open
lpkirwin opened this issue Jul 1, 2021 · 1 comment
Open

Visualiser slows down significantly over time #4

lpkirwin opened this issue Jul 1, 2021 · 1 comment
Labels
bug Something isn't working enhancement New feature or request

Comments

@lpkirwin
Copy link

lpkirwin commented Jul 1, 2021

To reproduce:

  • Load any replay
  • Play it at 16x speed
  • Hit the reset button (far left of the controls)
  • Play it at 16x speed again

Every time you reset, the rendering slows down on the next run. For me, second replay is half the speed of the first, and it gets worse from there. You can fix it by refreshing the page or re-uploading the replay.

Two thoughts:

  1. As a quick fix, should be easy to just do a hard refresh when someone hits the reset button?
  2. I haven't looked at the code, and I'm not a JS dev, but to me this strongly suggests that there's some unnecessary data accumulating over time as successive frames are rendered (e.g. an array that always gets pushed to, never overridden or emptied). If that's true, then fixing the underlying problem should improve the performance of the visualiser quite a bit.
@StoneT2000
Copy link
Member

thanks for pointing this out! we'll look into this.

@StoneT2000 StoneT2000 added bug Something isn't working enhancement New feature or request labels Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants