Fix w3c false issues #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is another fix at probably the correct level for https://www.drupal.org/project/drupal/issues/3458751#comment-15667563 |
longwave
reviewed
Jul 3, 2024
|
Closing and reopening in order to run the tests (see #11) |
alexpott
commented
Jul 4, 2024
| @@ -19,7 +19,23 @@ services: | |||
| - ddev-global-cache:/mnt/ddev-global-cache | |||
| chrome: | |||
| container_name: ddev-${DDEV_SITENAME}-chrome | |||
| image: selenium/standalone-chrome:latest | |||
| image: selenium/standalone-chromium:latest | |||
There was a problem hiding this comment.
This change to the chrome image allows ddev to work on arm laptops. selenium/standalone-chrome:latest is not available on arm... whereas selenium/standalone-chrome:4.8 is.... go figure.
There was a problem hiding this comment.
I suspect you might've already seen it, but there's this fairly recent post about multi-arch images. (Doesn't explain why it worked with 4.8, but it does speak as to why generally the chrome image doesn't support arm.)
chrfritsch
approved these changes
Jul 4, 2024
longwave
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.